Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(cubesql): Fix measure names for WideCube #8824

Merged
merged 1 commit into from
Oct 22, 2024
Merged

Conversation

mcheshkov
Copy link
Member

No description provided.

Copy link

vercel bot commented Oct 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 22, 2024 3:42pm

Copy link

codecov bot commented Oct 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (264f8da) to head (c59026e).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #8824   +/-   ##
=======================================
  Coverage   82.53%   82.53%           
=======================================
  Files         221      221           
  Lines       77572    77572           
=======================================
  Hits        64022    64022           
  Misses      13550    13550           
Flag Coverage Δ
cubesql 82.53% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mcheshkov mcheshkov force-pushed the fix-widecube-members branch 2 times, most recently from dfc80c8 to 0292acf Compare October 21, 2024 13:45
@mcheshkov mcheshkov marked this pull request as ready for review October 21, 2024 16:31
@mcheshkov mcheshkov requested a review from a team as a code owner October 21, 2024 16:31
@mcheshkov mcheshkov force-pushed the fix-widecube-members branch from 0292acf to 50afb92 Compare October 21, 2024 18:54
@mcheshkov mcheshkov force-pushed the fix-widecube-members branch from 50afb92 to c59026e Compare October 22, 2024 15:41
@mcheshkov mcheshkov merged commit 7def23b into master Oct 22, 2024
83 checks passed
@mcheshkov mcheshkov deleted the fix-widecube-members branch October 22, 2024 16:57
ptiurin pushed a commit to firebolt-db/cube that referenced this pull request Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants