Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api-gateway): OpenAPI - declare type field for Cube #8837

Merged
merged 6 commits into from
Oct 18, 2024

Conversation

ovr
Copy link
Member

@ovr ovr commented Oct 18, 2024

No description provided.

@ovr ovr requested review from a team as code owners October 18, 2024 12:01
Copy link

vercel bot commented Oct 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 18, 2024 0:38am

Copy link

codecov bot commented Oct 18, 2024

Codecov Report

Attention: Patch coverage is 77.46479% with 16 lines in your changes missing coverage. Please review.

Project coverage is 82.73%. Comparing base (9346f21) to head (367924b).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
...cubesql/cubeclient/src/models/v1_cube_meta_type.rs 11.11% 8 Missing ⚠️
rust/cubesql/cubeclient/src/models/v1_cube_meta.rs 0.00% 2 Missing ⚠️
...ql/cubeclient/src/models/v1_cube_meta_dimension.rs 0.00% 2 Missing ⚠️
...esql/cubeclient/src/models/v1_cube_meta_measure.rs 0.00% 2 Missing ⚠️
...sql/cubesql/src/compile/rewrite/rules/old_split.rs 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8837      +/-   ##
==========================================
- Coverage   82.74%   82.73%   -0.01%     
==========================================
  Files         220      221       +1     
  Lines       78260    78280      +20     
==========================================
+ Hits        64753    64763      +10     
- Misses      13507    13517      +10     
Flag Coverage Δ
cubesql 82.73% <77.46%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ovr ovr force-pushed the feat/cubeclient-cube-type branch from 2c1f5d9 to c62e16b Compare October 18, 2024 12:15
@ovr ovr changed the title feat(api-gateway): Declare type field for CubeMeta feat(api-gateway): OpenAPI - declare type field for CubeMeta Oct 18, 2024
@ovr ovr changed the title feat(api-gateway): OpenAPI - declare type field for CubeMeta feat(api-gateway): OpenAPI - declare type field for cube Oct 18, 2024
@ovr ovr changed the title feat(api-gateway): OpenAPI - declare type field for cube feat(api-gateway): OpenAPI - declare type field for Cube Oct 18, 2024
@ovr ovr merged commit 578b90c into master Oct 18, 2024
71 checks passed
@ovr ovr deleted the feat/cubeclient-cube-type branch October 18, 2024 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants