Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cubejs-client-core): fill missing dates with custom measure value #8843

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

nagulan23
Copy link

@nagulan23 nagulan23 commented Oct 20, 2024

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

#4604
#718

Description of Changes Made

Opens flexibility for users to provide custom value to be filled for the missing date.

@nagulan23 nagulan23 requested a review from a team as a code owner October 20, 2024 13:32
Copy link

vercel bot commented Oct 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 22, 2024 3:30pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Oct 20, 2024
@igorlukanin
Copy link
Member

Thanks for your contribution, @nagulan23 🙌

Could you also please update the docs on this page? https://cube.dev/docs/reference/frontend/cubejs-client-core

@nagulan23
Copy link
Author

@igorlukanin Have updated the doc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants