Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(redshift-driver): introspection for external schemas/tables (e.g. Spectrum) #8849

Merged
merged 21 commits into from
Oct 24, 2024

Conversation

KSDaemon
Copy link
Member

@KSDaemon KSDaemon commented Oct 21, 2024

This PR brings support for the introspection of external queries in AWS RedShift. External table properties in external schemas are returned with the common tables metadata. This is pretty useful in the case of using Redshift Spectrum.

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

@KSDaemon KSDaemon requested a review from a team as a code owner October 21, 2024 18:54
Copy link

vercel bot commented Oct 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Oct 24, 2024 10:31am

@KSDaemon KSDaemon force-pushed the feat/redshift-spectrum-schema branch 5 times, most recently from 4739eb0 to 0da9bcd Compare October 21, 2024 21:04
@KSDaemon KSDaemon force-pushed the feat/redshift-spectrum-schema branch from 8dfdddd to 89afdc1 Compare October 22, 2024 08:04
@KSDaemon KSDaemon force-pushed the feat/redshift-spectrum-schema branch from 89afdc1 to ba9f41f Compare October 22, 2024 08:57
@KSDaemon KSDaemon requested a review from a team as a code owner October 22, 2024 08:57
Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.53%. Comparing base (34dc819) to head (1ae6880).
Report is 13 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #8849      +/-   ##
==========================================
- Coverage   82.55%   82.53%   -0.02%     
==========================================
  Files         221      221              
  Lines       77830    77572     -258     
==========================================
- Hits        64249    64023     -226     
+ Misses      13581    13549      -32     
Flag Coverage Δ
cubesql 82.53% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KSDaemon KSDaemon force-pushed the feat/redshift-spectrum-schema branch from d2a9e41 to 3b3fa9f Compare October 22, 2024 16:51
@KSDaemon KSDaemon merged commit fa4b3b8 into master Oct 24, 2024
74 checks passed
@KSDaemon KSDaemon deleted the feat/redshift-spectrum-schema branch October 24, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants