ci(cubesql): Run unit tests for both top-down and bottom-up extractors #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #8884 +/- ##
==========================================
+ Coverage 82.44% 82.53% +0.09%
==========================================
Files 221 221
Lines 77696 77667 -29
==========================================
+ Hits 64059 64105 +46
+ Misses 13637 13562 -75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mcheshkov
force-pushed
the
ci-bottom-up-extraction
branch
from
96cd756 to
d06dfda
Compare
This case is already covered with compile::test::test_wrapper::test_wrapper_limit_zero
mcheshkov
force-pushed
the
ci-bottom-up-extraction
branch
from
d06dfda to
8507230
Compare
ptiurin
pushed a commit
to firebolt-db/cube
that referenced
this pull request
Nov 27, 2024
cube-js#8884) Also remove duplicated test_wrapper_limit_zero This case is already covered with compile::test::test_wrapper::test_wrapper_limit_zero
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List