feat(clickhouse-driver): Switch from apla-clickhouse to @clickhouse/client #8928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcheshkov
force-pushed
the
clickhouse-switch-driver
branch
from
7cf6692
to
6e9e184
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
clickhouse-switch-driver
branch
6 times, most recently
from
5455689
to
4340b01
Compare
This was referenced Nov 12, 2024
mcheshkov
force-pushed
the
clickhouse-switch-driver
branch
16 times, most recently
from
0438e83
to
e12f47e
Compare
…ToSeconds It returns input number (which should be seconds) as it is, and 5 for '5s'
mcheshkov
force-pushed
the
clickhouse-switch-driver
branch
from
e12f47e
to
3185910
Compare
mcheshkov
changed the title
paveltiunov
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Description of Changes Made (if issue reference is not provided)
Switch client library used to talk to ClickHouse to upstream one. Lots of related changes:
metafield in JSON format. Instread it relies onJSONCompactEachRowWithNamesAndTypes: first two rows returned should contain names and types. https://clickhouse.com/docs/en/sql-reference/formats#jsoncompacteachrowwithnamesandtypesgeneric-poolis not used at all,dbMaxPoolSizeis passed to client library to limit open sockets. New client maintainshttp.Agentinternally, and have it's own idle timers, looks fine for us.session_id, as we anyway expect queries to be independent, and don't use session-bound stuff, like temporary tables. Previous behaviour was kind of weird: session ids were attached to client in pool, but for every query it would pull acquire new client from pool, so nothing could actually utilize same session.KILL QUERYon cancellation now uses separate client instance, to avoid getting stuck on busy poolquerymethod supports onlySELECTqueries, or other queries that return result sets. For DDL queries on this client library one have to use other methods. Because of that more overrides were necessary, likedropTable,createSchemaIfNotExistsorcreateTable.dbQueryTimeoutconfig