fix(cubesql): Support explicit UTC as timezone in pushdown SQL generation #8971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #8971 +/- ##
==========================================
+ Coverage 82.66% 82.69% +0.02%
==========================================
Files 221 221
Lines 78303 78467 +164
==========================================
+ Hits 64727 64885 +158
- Misses 13576 13582 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
srh
approved these changes
Nov 19, 2024
mcheshkov
force-pushed
the
fix-now-in-pushdown
branch
from
f0b2559
to
991df86
Compare
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 8 Skipped Deployments
|
mcheshkov
force-pushed
the
fix-now-in-pushdown
branch
from
991df86
to
0fb5a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check List
Issue Reference this PR resolves
#8967
Description of Changes Made (if issue reference is not provided)
cubesql can introduce
ScalarValue::TimestampNanosecond(..., Some("UTC"))during constant folding, andgenerate_sql_for_exprtrips on unsupported timezones.This PR just allows
Noneas well asSome("UTC")as timezones. Because DataFusion will always generateUTC, it should be fine for now.See https://github.com/cube-js/arrow-datafusion/blob/dcf3e4aa26fd112043ef26fa4a78db5dbd443c86/datafusion/physical-expr/src/datetime_expressions.rs#L357-L367