Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix data access policies condition logic #8976

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Conversation

bsod90
Copy link
Contributor

@bsod90 bsod90 commented Nov 20, 2024

Data access policies conditions should be joined via AND operator, but the initial implementation used OR by mistake

Check List

  • Tests has been run in packages where changes made if available
  • Linter has been run for changed code
  • Tests for the changes have been added if not covered yet
  • Docs have been added / updated if required

Issue Reference this PR resolves

[For example #12]

Description of Changes Made (if issue reference is not provided)

[Description goes here]

@bsod90 bsod90 requested a review from a team as a code owner November 20, 2024 17:23
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

8 Skipped Deployments
Name Status Preview Comments Updated (UTC)
examples-angular-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-d3 ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-dashboard ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-data-table ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-highcharts ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-material-ui ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-react-pivot-table ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm
examples-vue-query-builder ⬜️ Ignored (Inspect) Visit Preview Nov 20, 2024 9:42pm

@github-actions github-actions bot added the pr:community Contribution from Cube.js community members. label Nov 20, 2024
Data access policies conditions should be joined via AND operator,
but the initial implementation used OR by mistake

Also ensured that rbac smoke tests are ran as part of the CI
@bsod90 bsod90 merged commit 47e7897 into master Nov 21, 2024
57 checks passed
@bsod90 bsod90 deleted the fix_dap_conditions branch November 21, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:community Contribution from Cube.js community members.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants