Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test(schema-compiler): Replace apla-clickhouse with @clickhouse/client #8978

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
+232 −202
Open

test(schema-compiler): Replace apla-clickhouse with @clickhouse/client #8978

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
39eeccf
fix(schema-compiler): Fix type annotation for buildSqlAndParams
mcheshkov Nov 21, 2024
dff63a5
test(schema-compiler): Rework TEST_CLICKHOUSE_HOST handling
mcheshkov Nov 21, 2024
9f49f97
test(schema-compiler): Port ClickHouseDbRunner to TypeScript
mcheshkov Nov 21, 2024
05984a2
refactor(schema-compiler): Move _normaliseResponse to static method
mcheshkov Nov 21, 2024
753141c
test(schema-compiler): Replace apla-clickhouse with @clickhouse/client
mcheshkov Nov 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/cubejs-schema-compiler/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"uuid": "^8.3.2"
},
"devDependencies": {
"@cubejs-backend/apla-clickhouse": "^1.7.0",
"@clickhouse/client": "^1.7.0",
"@cubejs-backend/linter": "^1.0.0",
"@cubejs-backend/query-orchestrator": "1.1.7",
"@types/babel__code-frame": "^7.0.6",
Expand Down
4 changes: 2 additions & 2 deletions packages/cubejs-schema-compiler/src/adapter/BaseQuery.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -577,9 +577,9 @@ export class BaseQuery {
}

/**
* Returns an array of SQL query strings for the query.
* Returns a pair of SQL query string and parameter values for the query.
* @param {boolean} [exportAnnotatedSql] - returns annotated sql with not rendered params if true
* @returns {Array<string>}
* @returns {[string, Array<unknown>]}
*/
buildSqlAndParams(exportAnnotatedSql) {
if (getEnv('nativeSqlPlanner')) {
Expand Down
194 changes: 0 additions & 194 deletions packages/cubejs-schema-compiler/test/integration/clickhouse/ClickHouseDbRunner.js
View file
Open in desktop

This file was deleted.

Loading
Loading