Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Install python3 executable for node-gyp #8998

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/cubejs-docker/dev.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -8,8 +8,9 @@ ENV CI=0

RUN DEBIAN_FRONTEND=noninteractive \
&& apt-get update \
# python3 package is necessary to install `python3` executable for node-gyp
&& apt-get install -y --no-install-recommends libssl3 curl \
cmake python3.11 libpython3.11-dev gcc g++ make cmake openjdk-17-jdk-headless \
cmake python3 python3.11 libpython3.11-dev gcc g++ make cmake openjdk-17-jdk-headless \
&& rm -rf /var/lib/apt/lists/*

ENV RUSTUP_HOME=/usr/local/rustup
Expand Down
3 changes: 2 additions & 1 deletion packages/cubejs-docker/latest-debian-jdk.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,8 +10,9 @@ RUN yarn config set network-timeout 120000 -g

# Required for node-oracledb to buld on ARM64
RUN apt-get update \
# python3 package is necessary to install `python3` executable for node-gyp
# libpython3-dev is needed to trigger post-installer to download native with python
&& apt-get install -y python3.11 libpython3.11-dev gcc g++ make cmake openjdk-17-jdk-headless \
&& apt-get install -y python3 python3.11 libpython3.11-dev gcc g++ make cmake openjdk-17-jdk-headless \
&& rm -rf /var/lib/apt/lists/*

# We are copying root yarn.lock file to the context folder during the Publish GH
Expand Down
3 changes: 2 additions & 1 deletion packages/cubejs-docker/latest.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,9 @@ RUN yarn config set network-timeout 120000 -g

# Required for node-oracledb to buld on ARM64
RUN apt-get update \
# python3 package is necessary to install `python3` executable for node-gyp
# libpython3-dev is needed to trigger post-installer to download native with python
&& apt-get install -y python3.11 libpython3.11-dev gcc g++ make cmake \
&& apt-get install -y python3 python3.11 libpython3.11-dev gcc g++ make cmake \
&& rm -rf /var/lib/apt/lists/*

# We are copying root yarn.lock file to the context folder during the Publish GH
Expand Down
5 changes: 3 additions & 2 deletions packages/cubejs-docker/local.Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,8 @@ ENV CUBEJS_DOCKER_IMAGE_TAG=latest

RUN DEBIAN_FRONTEND=noninteractive \
&& apt-get update \
&& apt-get install -y --no-install-recommends libssl3 python3.11 libpython3.11-dev \
# python3 package is necessary to install `python3` executable for node-gyp
&& apt-get install -y --no-install-recommends libssl3 python3 python3.11 libpython3.11-dev \
&& rm -rf /var/lib/apt/lists/*

ENV NODE_ENV=production
Expand All @@ -30,7 +31,7 @@ RUN yarn config set network-timeout 120000 -g

# Required for node-oracledb to buld on ARM64
RUN apt-get update \
&& apt-get install -y python3 gcc g++ make cmake \
&& apt-get install -y gcc g++ make cmake \
&& rm -rf /var/lib/apt/lists/*

# We are copying root yarn.lock file to the context folder during the Publish GH
Expand Down
Loading