Skip to content

Commit

Permalink
Merge pull request #13 from cubed-dev/fix-typo-and-default-value
Browse files Browse the repository at this point in the history
Fix `aggegrate_func` typo and default value for `drop_axis`
  • Loading branch information
tomwhite authored Apr 23, 2024
2 parents 7efd291 + 87f91e2 commit 46f83db
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 8 deletions.
7 changes: 1 addition & 6 deletions cubed_xarray/cubedmanager.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ def reduction(
arr,
func=func,
combine_func=combine_func,
aggegrate_func=aggregate_func, # TODO fix the typo in argument name in cubed
aggregate_func=aggregate_func,
axis=axis,
dtype=dtype,
keepdims=keepdims,
Expand All @@ -104,11 +104,6 @@ def map_blocks(
):
from cubed.core.ops import map_blocks

if drop_axis is None:
# TODO should fix this upstream in cubed to match dask
# see https://github.com/pydata/xarray/pull/7019#discussion_r1196729489
drop_axis = []

return map_blocks(
func,
*args,
Expand Down
2 changes: 1 addition & 1 deletion pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ requires-python = ">=3.9"
dependencies = [
"numpy >= 1.17",
"xarray >= 2024.02.0",
"cubed >= 0.6.3",
"cubed >= 0.14.2",
]

[project.urls]
Expand Down
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
cubed>=0.6.0
cubed>=0.14.2
numpy>=1.17.1
xarray>=2024.02.0

0 comments on commit 46f83db

Please sign in to comment.