Skip to content

Commit

Permalink
Fix Modal deprecation (show progress) and pip package (#634)
Browse files Browse the repository at this point in the history
Try running on Python 3.11
  • Loading branch information
tomwhite authored Dec 4, 2024
1 parent db25119 commit 9ef5cc6
Show file tree
Hide file tree
Showing 5 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/modal-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
fail-fast: false
matrix:
os: ["ubuntu-latest"]
python-version: ["3.10"]
python-version: ["3.11"]

steps:
- name: Checkout source
Expand Down
2 changes: 1 addition & 1 deletion cubed/runtime/executors/modal.py
Original file line number Diff line number Diff line change
Expand Up @@ -212,7 +212,7 @@ async def async_execute_dag(
check_runtime_memory(spec)
if "use_backups" not in kwargs and use_backups_default(spec):
kwargs["use_backups"] = True
async with app.run(show_progress=False):
async with app.run():
cloud = cloud or "aws"
if cloud == "aws":
app_function = run_remotely
Expand Down
2 changes: 1 addition & 1 deletion cubed/tests/runtime/test_modal.py
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ def deterministic_failure_modal_long_timeout(

async def run_test(app_function, input, use_backups=False, batch_size=None, **kwargs):
outputs = set()
async with app.run(show_progress=False):
async with app.run():
async for output in map_unordered(
app_function,
input,
Expand Down
2 changes: 1 addition & 1 deletion docs/requirements.txt
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
apache-beam
fsspec
lithops[aws] >= 2.7.0
modal-client
modal
mypy_extensions # for rechunker
networkx != 2.8.3, != 2.8.4, != 2.8.5, != 2.8.6, != 2.8.7, != 2.8.8, != 3.0.*, != 3.1.*, != 3.2.*
numpy >= 1.22
Expand Down
4 changes: 2 additions & 2 deletions pyproject.toml
Original file line number Diff line number Diff line change
Expand Up @@ -66,12 +66,12 @@ lithops-gcp = [
]
modal = [
"cubed[diagnostics]",
"modal-client",
"modal",
"s3fs",
]
modal-gcp = [
"cubed[diagnostics]",
"modal-client",
"modal",
"gcsfs",
]
coiled = [
Expand Down

0 comments on commit 9ef5cc6

Please sign in to comment.