Group by #442
Merged
Group by #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomwhite
added
core
xarray-integration
TomNicholas
reviewed
Apr 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
groupby_reductionfunction for doing "grouped reductions". This is intended for flox to add Cubed support.The only change needed to the regular
reductionfunction is the addition of acombine_sizesparameter, which makes it possible to specify the size of an axis after the combine function has been applied. In normal reductions the reduction axes are always 1 (thecombine_sizesdefault), but in a grouped reduction the axis representing the groups is instead the number of groups.