Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix set_time of ChoreStartTime class #686

Merged
merged 2 commits into from
Feb 10, 2022
Merged

Fix set_time of ChoreStartTime class #686

merged 2 commits into from
Feb 10, 2022
+9 −12

Conversation

samuelko123
Copy link
Contributor

It attempts to fix 2 issues:

  1. We cannot set minute to 0, because "if minute:" will evaluate to False. The same goes for other parameters.
  2. We would get "ValueError: day is out of range for month" if we set month to 2 while the original day is 31, vice versa.

@MariusWirtz
Copy link
Collaborator

Thanks for the fix!

@MariusWirtz MariusWirtz merged commit eee3944 into cubewise-code:master Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@samuelko123 @MariusWirtz