Add use_blob() to write() function to increase performance #881
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nction write_through_blob()
…nction write_through_blob()
…nction write_through_blob()
…nction write_through_blob()
write() use_blob=True
…nction write_through_blob()
floor
|
Wow, this is great! Thank you @cwffonseca I will immediately get to work to review! |
rclapp
reviewed
Mar 27, 2023
|
|
||
| # Create a TI processto load CSV data into the cube | ||
| dataload_process_name = 'cube.' + cube_name + '.load.fromfile.' + random_key + 'test' | ||
| dataload_process = Process(name=dataload_process_name, |
There was a problem hiding this comment.
Let's move the process creation to its own method. Perhaps a utility like "create_csv_load_process"
| # application_service.delete(path='', application_type='FOLDER', application_name='TM1py') | ||
|
|
||
| # Delete CSV file local | ||
| os.remove(export_path_to_file) |
There was a problem hiding this comment.
We should also add a parameter to clean up the applications folder
There was a problem hiding this comment.
Let's discuss this in #882
Yeah. I think we could make this optional. If the function is called in parallel though, it would be a nuisance if a separate thread, process, or application removed the tm1py folder in though...
|
Thanks for the review @rclapp. |
Merged
|
closed in favor of #882 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #848
Added
use_blobparameter to functionwrite(), and added underlying functionwrite_through_blob()to increase performance of writing to cells.This function uploads a CSV file, and then runs a TI process which uses this CSV as data source to load data to a cube.