Get 2times image size

[osamunmun]

I use version 0.7.0. Without dw and dh request, the image size looks like 2 times.
Maybe MagickGetImage.. in ngx_http_small_light_imagemagick.c return wrong size?

/* calc size. */
    iw = (double)MagickGetImageWidth(ictx->wand);
    ih = (double)MagickGetImageHeight(ictx->wand);
    ngx_http_small_light_calc_image_size(r, ctx, &sz, iw, ih);

• request logs
  Attached image size is 774x432, but sw and sh is sw=1548,sh=864.

2016/07/08 04:04:10 [notice] 42#0: *16 "^" matches "/small_light(q=95,jpeghint=y,of=jpg)/img/test.jpg", client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,of=jpg)/img/test.jpg HTTP/1.0", host: "127.0.0.1:8081"
2016/07/08 04:04:10 [notice] 42#0: *16 rewritten data: "/img/test.jpg", args: "", client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,of=jpg)/img/test.jpg HTTP/1.0", host: "127.0.0.1:8081"
2016/07/08 04:04:10 [notice] 42#0: *16 size info:sx=0,sy=0,sw=10000,sh=10000,dw=9223372036854775808,dh=9223372036854775808,cw=0,ch=0,bw=0,bh=0,ix=0,iy=0 while sending to client, client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,of=jpg)/img/test.jpg HTTP/1.0", upstream: "http://172.20.10.3:4567/test.jpg", host: "127.0.0.1:8081"
2016/07/08 04:04:10 [debug] 42#0: *16 jpeg_size_opt:10000x10000
2016/07/08 04:04:10 [notice] 42#0: *16 size info:sx=0,sy=0,sw=1548,sh=864,dw=9223372036854775808,dh=9223372036854775808,cw=0,ch=0,bw=0,bh=0,ix=0,iy=0 while sending to client, client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,of=jpg)/img/test.jpg HTTP/1.0", upstream: "http://172.20.10.3:4567/test.jpg", host: "127.0.0.1:8081"

[cubicdaiya]

Hi @osamunmun ,

Thank you for the report. I'm working at #47.

[osamunmun]

Thanks!

[cubicdaiya]

Fixed in #47.

[osamunmun]

In only cw, ch params given without dw,dh case, NGX_HTTP_SMALL_LIGHT_COORD_INVALID_VALUE(1.e+38) is still used?

[notice] 23#0: *20 "^" matches "/small_light(q=95,jpeghint=y,da=s,cw=200,ch=200,of=jpg)/img/test.jpg", client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,da=s,cw=200,ch=200,of=jpg)/img/test.jpg HTTP/1.0", host: "127.0.0.1:8081"
[notice] 23#0: *20 rewritten data: "/img/test.jpg", args: "", client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,da=s,cw=200,ch=200,of=jpg)/img/test.jpg HTTP/1.0", host: "127.0.0.1:8081"
[notice] 23#0: *20 size info:sx=0,sy=0,sw=10000,sh=10000,dx=-9223372036854775808,dy=-9223372036854775808,dw=9223372036854775808,dh=9223372036854775808,cw=200,ch=200,bw=0,bh=0,ix=0,iy=0 while sending to client, client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,da=s,cw=200,ch=200,of=jpg)/img/test.jpg HTTP/1.0", upstream: "http://192.168.11.12:4567/test.jpg", host: "127.0.0.1:8081"
[notice] 23#0: *20 size info:sx=0,sy=0,sw=774,sh=432,dx=-9223372036854775808,dy=-9223372036854775808,dw=9223372036854775808,dh=9223372036854775808,cw=200,ch=200,bw=0,bh=0,ix=0,iy=0 while sending to client, client: 127.0.0.1, server: , request: "GET /small_light(q=95,jpeghint=y,da=s,cw=200,ch=200,of=jpg)/img/test.jpg HTTP/1.0", upstream: "http://192.168.11.12:4567/test.jpg", host: "127.0.0.1:8081"

[cubicdaiya]

dw and dh are assigned after the process above. And I fixed about dx and dy in 9f89002.

[cubicdaiya]

Sorry. As I was mistaken, 9f89002 was reverted and I re-fixed in c38e592.

[cubicdaiya]

In only cw, ch params given without dw,dh case, NGX_HTTP_SMALL_LIGHT_COORD_INVALID_VALUE(1.e+38) is still used?
dw and dh are assigned after the process above.

FYI, It's the same for dx and dy.

[osamunmun]

Thank you for your quick fix.
If cw, ch params are given without dw, dh, crop start coordinate is (0, 0) not center of image.
Sorry I tried to fix this, but I cannot.

[cubicdaiya]

If cw, ch params are given without dw, dh, crop start coordinate is (0, 0) not center of image.

Usually such as the case should be rare. But it seems to be good that cropping the center by default in the such case.

[cubicdaiya]

Hi @osamunmun,

Modified the behavior in b7a4cce.

[osamunmun]

Thank you so much!