Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supports SDXL PuLID v1.1 #125

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Supports SDXL PuLID v1.1 #125

wants to merge 1 commit into from

Conversation

vitrun
Copy link

@vitrun vitrun commented Dec 19, 2024

To verify the functionality, you can either install it and run in ComfyUI workflow or use the provided test script as follows:

cd parent_dir_of_PuLID_ComfyUI
PYTHONPATH="/path/to/ComfyUI/:$PYTHONPATH" python -m PuLID_ComfyUI.test

The ip-adapter style weights can be downloaded from ip-adapter-pulid

Simple test shows a slight improvement in face similarity:
v1:
image
v1.1:
image

@Slickytail
Copy link

Haha, you beat me to it by a few hours, I was about to submit my PR. Looking forward to having this merged and available, anyway.

@vitrun
Copy link
Author

vitrun commented Dec 20, 2024

Hi @Slickytail ,

I must admit that I'm not entirely confident about the accuracy of my implementation. Based on the experiments, v1.1 combined with Diffusers seems to yield better results when all the params aligned as per my understanding. But I don't have the time to investigate this further. Therefore, welcome to conduct a code review of this PR or submit your PR if you have suggestions or improvements. Thanks!

@Slickytail
Copy link

@vitrun My version was exactly the same as yours: replace the IDEncoder with IDFormer, convert the checkpoint, and call it a day. I haven't tested the diffusers version of it, but my results have seemed pretty good so far....

@Slickytail
Copy link

hi @xps2020, it looks like you're using the pulid1.1 checkpoint but with the 1.0 code. To use the 1.1 checkpoint you'll have to install vitrun's version of the code. In your error message it says it's trying to load an IDEncoder model. The v1.1 model is called IDFormer.

@firofame
Copy link

firofame commented Jan 6, 2025

@cubiq gentle reminder :)

@firofame firofame mentioned this pull request Jan 6, 2025
@mykeehu
Copy link

mykeehu commented Feb 14, 2025

When will this be integrated?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants