-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup and update names #2
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you renamed the files (I did not know that you could do that this way). The small fixes are also great.
However, please remove the renaming of fals
and tru
. I do not want to change that.
I'm curious why you prefer |
I don't see a reason to change it. |
It follows established style guidelines, with examples including:
|
It does not matter. I currently do not want to do the work involved in changing all uses of this API without added functionality. |
I deprecated the old names, so it should still work. |
|
This PR makes the following changes:
tru
->true
andfals
->false
.mod.rs
structure with the newer idiomatic structure.Some questions: does
#[inline]
actually achieve anything (on the constructors for truth-y values)? Won't the compiler be smart enough to choose to inline (or not) when it deems necessary?