Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduces VRT + Github Actions #17

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Introduces VRT + Github Actions #17

wants to merge 8 commits into from

Conversation

Atsumi3
Copy link
Member

@Atsumi3 Atsumi3 commented Aug 7, 2023

Ticket

変更内容

VRTを導入するために package.jsonを更新した
VRT用の Github Actions を追加した.

確認方法

このブランチでは追加したコードを見るだけ。
マージ後の次のPRで色々調整していきます。

Screenshot (任意)

@Atsumi3 Atsumi3 requested a review from takecchi August 7, 2023 17:53
@Atsumi3 Atsumi3 self-assigned this Aug 7, 2023
@Atsumi3 Atsumi3 added the feature 新しい機能の追加 label Aug 7, 2023
@Atsumi3 Atsumi3 marked this pull request as draft August 7, 2023 18:05
@Atsumi3 Atsumi3 marked this pull request as ready for review August 7, 2023 18:16
@Atsumi3 Atsumi3 temporarily deployed to develop August 7, 2023 18:32 — with GitHub Actions Inactive
@reg-suit
Copy link

reg-suit bot commented Aug 7, 2023

reg-suit detected visual differences.

Check this report, and review them.

What do the circles mean? The number of circles represent the number of changed images.
🔴 : Changed items, ⚪ : New items, ⚫ : Deleted items, and 🔵 Passed items

How can I change the check status? If reviewers approve this PR, the reg context status will be green automatically.

@Atsumi3 Atsumi3 temporarily deployed to develop August 7, 2023 19:03 — with GitHub Actions Inactive
@Atsumi3 Atsumi3 temporarily deployed to develop August 7, 2023 19:04 — with GitHub Actions Inactive
@Atsumi3 Atsumi3 marked this pull request as draft August 7, 2023 19:25
@takecchi
Copy link
Member

残課題

  • S3直置きパブリック公開前提になってしまっている
  • CloudFrontを挟む?公開方法要検討

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 新しい機能の追加
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants