Skip to content

Upgrade nom to 8.0 #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jan 28, 2025
Merged

Upgrade nom to 8.0 #14

merged 5 commits into from
Jan 28, 2025

Conversation

tyranron
Copy link
Member

@tyranron tyranron commented Jan 28, 2025 •
edited
Loading

Synopsis

nom 8.0 has been released.

Changelog

Solution

Since nom_locate crate hasn't been active since 2 years, it will unlikely migrate fast to 8.0 nom. There is also an alternative nom-span crate, a little bit more maintained, however, still not hurrying to migrate to new nom version. Thus, this PR vendors a shrank version of nom_locate with only the functionality we need.

Checklist

  • Tests updated
  • Docs updated
  • CHANGELOG entry added

@tyranron tyranron added enhancement Improvement of existing features or bugfix semver::breaking Breaking change in terms of SemVer k::dependencies Pull requests that update a dependency file rust Pull requests that update Rust code labels Jan 28, 2025
@tyranron tyranron self-assigned this Jan 28, 2025
@tyranron tyranron added the k::refactor Refactoring, technical debt elimination and other improvements of existing code base label Jan 28, 2025
@tyranron tyranron marked this pull request as ready for review January 28, 2025 19:01
@tyranron tyranron merged commit 750de24 into main Jan 28, 2025
25 checks passed
@tyranron tyranron deleted the nom-0.8 branch January 28, 2025 19:02
tyranron added a commit that referenced this pull request Feb 3, 2025
@tyranron
Switch back to upstream 5.0 nom_locate crate (#14)
356024e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tyranron tyranron

Labels
enhancement Improvement of existing features or bugfix k::dependencies Pull requests that update a dependency file k::refactor Refactoring, technical debt elimination and other improvements of existing code base rust Pull requests that update Rust code semver::breaking Breaking change in terms of SemVer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@tyranron