Skip to content

Add special naming for every regex capture group in Parameter (#7) #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 10, 2022
Merged

Add special naming for every regex capture group in Parameter (#7) #8

merged 6 commits into from
Feb 10, 2022

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Feb 8, 2022 •
edited by tyranron
Loading

Part of #7

Synopsis

Currently string parameter regex group leaves quotes.

Solution

Add __<parameter_id>_<group_id> name every parameter regex capture group and handle it as a special case in cucumber-codegen crate (cucumber-rs/cucumber#204).

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv self-assigned this Feb 8, 2022
@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Feb 8, 2022
@ilslv ilslv added this to the 0.2.0 milestone Feb 8, 2022
@ilslv ilslv linked an issue Feb 8, 2022 that may be closed by this pull request
Incorrect extracting of {string} #7
Closed
@ilslv ilslv requested a review from tyranron February 8, 2022 08:43
@ilslv
Copy link
Member Author

ilslv commented Feb 8, 2022 •
edited by tyranron
Loading

FCM

Add special naming for every `regex` capturing group in `Parameter` (#8, #7)

@ilslv ilslv mentioned this pull request Feb 8, 2022
Merged
15 tasks
tyranron
tyranron requested changes Feb 8, 2022
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed.

@ilslv ilslv requested a review from tyranron February 9, 2022 12:11
@ilslv ilslv changed the title Add name to string parameter regex capture group Add special naming for every regex capture group in parameter (#7) Feb 9, 2022
@ilslv ilslv changed the title Add special naming for every regex capture group in parameter (#7) Add special naming for every regex capture group in Parameter (#7) Feb 9, 2022
@tyranron tyranron added the semver::breaking Breaking change in terms of SemVer label Feb 10, 2022
@tyranron tyranron merged commit 5624857 into main Feb 10, 2022
@tyranron tyranron deleted the 7-add-parameter-id branch February 10, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels
enhancement Improvement of existing features or bugfix semver::breaking Breaking change in terms of SemVer
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Incorrect extracting of {string}
2 participants
@ilslv @tyranron