Fail background skipped tests

[rogertorres]

Currently, running a test with fail_on_skipped() does not fail Background skipped tests. The reason is because the Background steps are not being mapped as the steps directly under the Scenario are:

cucumber/src/writer/fail_on_skipped.rs

Lines 92 to 95 in 935602b

	Cucumber::Feature(
	f,
	Feature::Scenario(sc, Scenario::Step(st, Step::Skipped)),
	) => map_failed(f, None, sc, st),

If that was the only thing that needed to be changed, it would be easy (spoiler: it is not); all it takes is to copy code above and replace Scenario::Step with Scenario::Background.

Cucumber::Feature(
    f,
    Feature::Scenario(sc, Scenario::Background(st, Step::Skipped)),
) => map_failed(f, None, sc, st),

It does work, but it also leads to another issue. Once we force skipped background steps to fail, we should also allow the usage of @allow.skipped on these steps, which is not possible because, as you clearly stated, we cannot use tags above Background.

I know you guys went deep redesigning this, so I want to understand your reasoning before proposing anything or making changes locally. My questions are:

• To fail skipped Background tests is not available by design?
• What is the reason for not allowing tags above Background?

Thank you!

[ilslv]

@rogertorres thanks for detailed report and diving into code!

To fail skipped Background tests is not available by design?

No, this definitely was overlooked.

It does work, but it also leads to another issue. Once we force skipped background steps to fail, we should also allow the usage of @allow.skipped on these steps, which is not possible because, as you clearly stated, we cannot use tags above Background.

Actually I don't think this is an issue, because you can still use @allow.skipped on all Scenarios that are using skipped Backgrounds in case you don't want them to fail. This approach is even better than using @allow.skipped on Background, because it's more clear what Scenarios aren't tested. So solution you have provided should be enough.

I will happily review your PR in case it's possible or fix this myself.

[rogertorres]

@ilslv This makes total sense!

I submitted a minimal PR, which I tested locally. I was wondering if it would not be a good idea to add some tests and/or a tip on the book. This is something I could do, but I would then need more time/help to really understand how you organized things there.

[tyranron]

@rogertorres fix has been released in 0.11.2 version.

[rogertorres]

@tyranron Thank you!