-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update inventory requirement from 0.1.10 to 0.2.0 #158
Conversation
Updates the requirements on [inventory](https://github.com/dtolnay/inventory) to permit the latest version. - [Release notes](https://github.com/dtolnay/inventory/releases) - [Commits](dtolnay/inventory@0.1.10...0.2.0) --- updated-dependencies: - dependency-name: inventory dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
cc @ilslv |
@tyranron this became quite a rabbit hole. For now we are generating 3 structs (each for pub trait StepConstructor<W> {
fn new(_: step::Location, _: Regex, _: Step<W>) -> Self;
fn inner(&self) -> (step::Location, Regex, Step<W>);
} This is done to have an ability to construct those struct using only Then I've tried ditching So the only way I see this can be possible on stable Rust is to #[derive(Clone, Copy)]
#[repr(C)]
pub struct SyncFriend(*const ());
#[allow(unsafe_code)]
unsafe impl Sync for SyncFriend {} All this does work, but unfortunately we have to expand code with |
Maybe we can workaround it with introducing in-place type alias? |
@tyranron in-place type alias still runs into |
@ilslv ahaha... brilliant! 🙈 What we love Rust for - is squating 😁 |
@ilslv so, is it ready for review then? If so, request the one please. |
@tyranron not yet, as I've just discovered this trick. I'll request review, once it's done |
FCM
|
Updates the requirements on inventory to permit the latest version.
Release notes
Sourced from inventory's releases.
Commits
71b6c1f
Release 0.2.07d81709
Document compiler requirement of 1.378291011
Add ui test of nonconst constructionb499293
Merge pull request #43 from dtolnay/constb853350
Require inventory element type to be const constructed762b5ce
Merge pull request #42 from dtolnay/syncea173f9
Add ui test of sync bounde1e347d
Require inventory element type to be Sync95501ae
Merge pull request #41 from dtolnay/macrorules4a6f321
Import inventory-impl macros into inventory crateDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)