Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use std::io::IsTerminal instead of is_terminal #288

Merged
merged 5 commits into from
Jun 29, 2023
Merged

Use std::io::IsTerminal instead of is_terminal #288

merged 5 commits into from
Jun 29, 2023

Conversation

SonnyX
Copy link
Contributor

@SonnyX SonnyX commented Jun 13, 2023

Now that the IsTerminal trait is stable in Rust 1.70, we can switch to it:
https://blog.rust-lang.org/2023/06/01/Rust-1.70.0.html#isterminal

tyranron
tyranron requested changes Jun 22, 2023
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonnyX thank you! But this also requires bumping up MSRV up to 1.70. Please, do that.

@tyranron tyranron added enhancement Improvement of existing features or bugfix k::refactor Refactoring, technical debt elimination and other improvements of existing code base labels Jun 22, 2023
@tyranron tyranron added this to the 0.20.0 milestone Jun 22, 2023
@tyranron tyranron added the semver::breaking Represents breaking changes label Jun 22, 2023
tyranron
tyranron approved these changes Jun 29, 2023
View reviewed changes
Copy link
Member

@tyranron tyranron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SonnyX nice job! Thanks! 🍻

@tyranron tyranron added the k::documentation Related to project documentation label Jun 29, 2023
@tyranron tyranron merged commit d7179de into cucumber-rs:main Jun 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@SonnyX SonnyX

Labels
enhancement Improvement of existing features or bugfix k::documentation Related to project documentation k::refactor Refactoring, technical debt elimination and other improvements of existing code base semver::breaking Represents breaking changes
Projects
None yet
Milestone
0.20.0
Development

Successfully merging this pull request may close these issues.
2 participants
@SonnyX @tyranron