Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document how to update python dependencies #8

Closed
aslakhellesoy opened this issue Jun 12, 2022 · 5 comments · Fixed by #18
Closed

Document how to update python dependencies #8

aslakhellesoy opened this issue Jun 12, 2022 · 5 comments · Fixed by #18

Comments

@aslakhellesoy
Copy link
Contributor

🤔 What's the problem you're trying to solve?

Make a release of Cucumber Expressions with as many dependencies as possible updated.

✨ What's your proposed solution?

Document how to do it for python.

⛏ Have you considered any alternatives or workarounds?

Not sure what to make of this: python-poetry/poetry#461

📚 Any additional context?

I think some projects are using pyproject.toml while others are using requirements.txt.
Can we settle on one? In the meanwhile, what's the correct way to update dependencies in both?

Amy suggestions @jenisys @jsa34 @brasmusson
@mattwynne
Copy link
Member

What's this issue doing in this repo? Should we move it to cucumber/cucumber-expressions?

@mpkorstanje
Copy link
Contributor

mpkorstanje commented Oct 13, 2022 •
edited
Loading

@mattwynne I think he's following the release instructions that say to update the depencies before release. I usually don't bother with that. It's what renovate is for.

Also, updating depencies just before you release is asking for problems. Making a release is - assuming the process works - an activity wich needs a fixed amount of time. Updating depencies is an unbounded time activity.

I would suggest moving the update dependency step to the post release process. I would also suggest adding a note to investigate why Renovate didn't pick them up rather then updating them by hand.

@jsa34
Copy link

jsa34 commented Oct 13, 2022 •
edited
Loading

Apologies - I missed this issue.

Ideally, we can add/fix renovate to make automated updates for the pyproject.toml and poetry.lock files: here (Not sure if it should be enabled by default)

The package itself (not including tests) doesn't have any dependencies other than Python itself which is why it didn't even cross my mind to check if Renovate was working.

There is a "manual" command that can be run to update dependencies across the board for Poetry projects, but with pyproject.toml files supported by renovate, perhaps that's a better way to go.

Renovate also updates dependencies in requirements.txt files, so it is consistent across packaging solutions.

Agree completely, @mpkorstanje - should be done post-release or in dev phase.

We should also probably use a common packaging solution across Python projects, too - that's probably my fault for sticking Poetry in the mix, but happy to rework to whatever a common consensus is :)

@mpkorstanje
Copy link
Contributor

Ideally, we can add/fix renovate to make automated updates for the pyproject.toml and poetry.lock files: here (Not sure if it should be enabled by default)

Looking at the history it looks like Renovate has picked up Poetry and PyProject files just fine:

We should also probably use a common packaging solution across Python projects, too - that's probably my fault for sticking Poetry in the mix, but happy to rework to whatever a common consensus is :)

Would be nice, but for the current discussion having more then 1 solution is not a problem. Renovate supports both.

@mpkorstanje mpkorstanje mentioned this issue Oct 13, 2022
Merged
@jsa34
Copy link

jsa34 commented Oct 13, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove upgrade step from the release process cucumber/.github
4 participants
@aslakhellesoy @mattwynne @mpkorstanje @jsa34