Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove code supporting cucumber 3 from simplecov set-up #868

Merged
merged 1 commit into from
Apr 23, 2022

Conversation

mvz
Copy link
Contributor

@mvz mvz commented Apr 23, 2022

Summary

Removes obsolete support for Cucumber 3 from features/support/env.rb.

Details

With Cucumber 4, scenario.feature stopped working in a Before do |scenario| block. Since Aruba no longer supports Cucumber below version 4, the code path for using scenario.feature was obsolete and has now been removed.

Additionally, the parameter for a Before block is no longer a scenario. Instead, it's a test case. I've adjusted the parameter name accordingly. More details here: cucumber/cucumber-ruby#1432.

Motivation and Context

I came across cucumber/cucumber-ruby#1432 and decided to clean things up.

How Has This Been Tested?

I ran one cucumber feature file.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Internal change (refactoring, test improvements, developer experience or update of dependencies)

Checklist:

  • I've added tests for my code
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@mvz mvz merged commit 10f753f into main Apr 23, 2022
@mvz mvz deleted the update-simplecov-command-name branch April 23, 2022 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant