Fix SimpleCov integration #933
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The way Aruba's environment manipulation currently works, when running
code or child processes in a nested environment, the priority of how the
environment variables are set is like this:
1. Variables set with Aruba's environment manipulation methods
2. Variables set in ENV when Aruba's environment manipulation object
(aruba.environment) was initialized
3. Variables set in ENV after aruba.environment was initialized
I'm not convinced the order of 2. and 3. is the right order, but due to
this order, setting RUBYOPT directly on ENV had no effect because there
was already a variable RUBYOPT set at the point of initializion of
aruba.environment.
By using the environment manipulation methods, the values set here will
take first priority regardless of whether the variables were set
earlier.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Activates simplecov on nested processes. It works, but makes the tests very slow. Based on #898 but with a more minimal change.
This should probably be hidden behind an environment variable.
Details
Motivation and Context
PR #898 is stale.
How Has This Been Tested?
I ran cukes. It looks like it tries to calculate coverage for files in
tmp/, and maybe even loads simplecov inside thearuba-test-cliand other test executables.Types of changes
Checklist: