Unify RuboCop configuration with other Cucumber projects #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This brings Aruba more in line with other Cucumber Ruby code.
This brings Aruba more in line with other Cucumber Ruby code.
This brings Aruba more in line with other Cucumber Ruby code.
This replace #have_received style mocking with #received style, which is the style used in other Ruby code in the Cucumber project
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Update the RuboCop configuration to match other Cucumber projects. This is not an exact science, since not all RuboCop configurations are identical.
Details
Motivation and Context
This helps contributors to Cucumber contribute to Aruba without having to worry about having to adhere to different RuboCop rules. See #935 (comment)
How Has This Been Tested?
I ran RuboCop and the changed spec files.
Types of changes