Skip to content

Fix post-release for Go when there is no "replacements" #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
vincent-psarga opened this issue Oct 28, 2019 · 2 comments
Closed

Fix post-release for Go when there is no "replacements" #774

vincent-psarga opened this issue Oct 28, 2019 · 2 comments
Assignees
@vincent-psarga
Labels
⌛ stale Will soon be closed by stalebot unless there is activity language: go 🔧 build Related to build / release process

Comments

@vincent-psarga
Copy link
Contributor

Summary

With latest release of cucumber-expressions, the go.mod file was broken by the post-release target.

See 9e728e5

This is due to the fact that this package has no replacements.

Expected Behavior

post-release task should not break the package :)

Possible Solution

Steps to Reproduce (for bugs)

Context & Motivation

Your Environment

  • Version used:
  • Operating System and version:
  • Link to your project:
@vincent-psarga vincent-psarga added language: go 🔧 build Related to build / release process labels Oct 28, 2019
@vincent-psarga vincent-psarga self-assigned this Oct 28, 2019
vincent-psarga added a commit that referenced this issue Oct 31, 2019
@vincent-psarga
Do not try to add replace in go.mod when there is no need (see #774)
cb50724
@vincent-psarga vincent-psarga mentioned this issue Oct 31, 2019
Merged
11 tasks
mpkorstanje added a commit that referenced this issue Oct 31, 2019
@mpkorstanje
Merge pull request #780 from cucumber/774-fix-go-add-remove-replaces
23193e2 
Release process: do not try to add replace in go.mod when there is no need (see #774)
@aslakhellesoy aslakhellesoy mentioned this issue Oct 31, 2019
Merged
11 tasks
@stale
Copy link

stale bot commented Dec 27, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in a week if no further activity occurs.

@stale stale bot added the ⌛ stale Will soon be closed by stalebot unless there is activity label Dec 27, 2019
@stale
Copy link

stale bot commented Jan 3, 2020

This issue has been automatically closed because of inactivity. You can support the Cucumber core team on opencollective.

@stale stale bot closed this as completed Jan 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vincent-psarga vincent-psarga

Labels
⌛ stale Will soon be closed by stalebot unless there is activity language: go 🔧 build Related to build / release process
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincent-psarga