Gherkin rsync testdata #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subrepo: subdir: "gherkin/c" merged: "f1b4d66" upstream: origin: "https://github.com/cucumber/gherkin-c.git" branch: "master" commit: "f1b4d66" git-subrepo: version: "0.4.0" origin: "https://github.com/ingydotnet/git-subrepo" commit: "b5d1ba1"
This makes each subrepo mirror autonomous.
|
This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Use
rsyncto copy files to subrepos.Details
Each subrepo that wishes to have copies of other files can declare what files or directories to copy in an
.rsyncfile.The
rsync_filesfunction fromscripts/functions.shcan then be used to perform a sync.Motivation and Context
The subrepos such as
cucumber/gherkin-java,cucumber/gherkin-rubyetc. haven't been autonomous prior to this change. TheirMakefilewould refer to files in the parent directory, which doesn't exist when the subrepo is cloned.This poses a problem for CI, because the full test suite can't run unless all files are available.
How Has This Been Tested?
Manually for now. As soon as this is merged and subrepos pushed, we'll fix any remaining issues highlighted by CI
Screenshots (if appropriate):
Types of changes
Checklist: