Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dutch translation for Rule #1513

Merged
merged 3 commits into from
May 15, 2021
Merged

Conversation

OrhanTozan
Copy link
Contributor

Summary

Details

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • The change has been ported to Java.
  • The change has been ported to Ruby.
  • The change has been ported to JavaScript.
  • The change has been ported to Go.
  • The change has been ported to .NET.
  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

@aurelien-reeves
Copy link
Contributor

Hello @OrhanTozan

Thank you for your contribution.

Updating translation actually requires a little bit more changes.

Could you please take a look on other places where updates are required?

You can take some inspiration from another PR like the following one if you need to: #1499

@gasparnagy
Copy link
Member

@OrhanTozan Check https://github.com/cucumber/cucumber/blob/master/gherkin/CONTRIBUTING.md#adding-or-updating-an-i18n-language that describes the steps to be done to distribute the change to all languages

@aurelien-reeves aurelien-reeves added ⚡ enhancement Request for new functionality good first issue Good for newcomers library: gherkin labels May 7, 2021
@aslakhellesoy aslakhellesoy merged commit cb10bc6 into cucumber:master May 15, 2021
@aslakhellesoy
Copy link
Contributor

Hi @OrhanTozan,

Thanks for your making your first contribution to Cucumber, and welcome to the Cucumber committers team! You can now push directly to this repo and all other repos under the cucumber organization! 🍾

In return for this generous offer we hope you will:

  • ✅ Continue to use branches and pull requests. When someone on the core team approves a pull request (yours or someone else's), you're welcome to merge it yourself.
  • 💚 Commit to setting a good example by following and upholding our code of conduct in your interactions with other collaborators and users.
  • 💬 Join the community Slack channel to meet the rest of the team and make yourself at home.
  • ℹ️ Don't feel obliged to help, just do what you can if you have the time and the energy.
  • 🙋 Ask if you need anything. We're looking for feedback about how to make the project more welcoming, so please tell us!

On behalf of the Cucumber core team,
Aslak Hellesøy
Creator of Cucumber

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers library: gherkin ⚡ enhancement Request for new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants