Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Smaller docker build images #1627

Closed
wants to merge 4 commits into from
Closed

Smaller docker build images #1627

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f117945
Add a new 'in-docker' make target for messages javascript
mattwynne Jun 22, 2021
c129dd5
Add bash to docker image (needed by default.mk)
mattwynne Jun 22, 2021
c97640f
Experiment with mapping entire monorepo as a volume
mattwynne Jun 22, 2021
8dce692
Merge branch 'main' into smaller-docker-images
aslakhellesoy Aug 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
FROM node:16.3.0-alpine3.13 as javascript
RUN apk add make --no-cache
RUN apk add bash --no-cache
5 changes: 5 additions & 0 deletions messages/javascript/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@ include default.mk

JSONSCHEMAS = $(shell find ../jsonschema -name "*.json")

in-docker: .codegen
docker image build --target javascript --tag cucumber/build-javascript --file ../../Dockerfile .
docker run --volume ${shell pwd}/../..:/app --workdir /app/messages/javascript --entrypoint "/usr/bin/make" --tty cucumber/build-javascript clean
docker run --volume ${shell pwd}/../..:/app --workdir /app/messages/javascript --entrypoint "/usr/bin/make" --tty cucumber/build-javascript

.codegen: src/messages.ts

src/messages.ts: $(JSONSCHEMAS) ../jsonschema/scripts/codegen.rb
Expand Down