[perl] build, test and release improvements #1728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since the [Git::GatherDir] plugin for Dist::Zilla *only* gathers versioned files and the CHANGELOG.md file is *not* versioned, but rather copied into the project directory upon release, it needs to be explicitly included in the distribution tar file. Also, in order to reduce the number of files a developer needs to get to know, move the ignore patterns from `MANIFEST.SKIP` to `dist.ini`, eliminating the need to have `MANIFEST.SKIP` at all.
…d Makefile In case of Gherkin, use this centralization to add the in-repository path for Cucumber::Messages in case we're running in the CI environment.
1. `clobber` target removes generated files (`clean` does not) 2. `clean` target removes "imported" `CHANGELOG.md` Note that the CHANGES file hasn't existed for a long time...
ehuelsmann
added
🐛 bug
aurelien-reeves
approved these changes
Sep 7, 2021
|
Thanks for the review! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Main improvement is the release improvement where CHANGELOG.md wasn't included in Gherkin-21.0.0 because it's an unversioned file. On the Cucumber::Messages release, it was included because it was a versioned file until the post-release step removed it.
Details
cleantargets between Gherkin and Cucumber::Messages, wherecleandoes not remove generated files (andclobberdoes)Motivation and Context
Correct releases, Alignment of infrastructure between various Perl libraries inside a single repo and preparation to integrate Cucumber::Messages into Gherkin.
How Has This Been Tested?
Rerunning
make distributionand verifying the content of the distribution tarball.Types of changes
Checklist: