Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tag-expressions/perl] Implementation of tag-expressions for Perl #1782

Merged
merged 2 commits into from
Oct 8, 2021

Conversation

ehuelsmann
Copy link
Contributor

@ehuelsmann ehuelsmann commented Oct 7, 2021

Summary

This PR implements tag-expressions for Perl. It includes tests and release infrastructure.

Details

The parser is implemented in Cucumber::TagExpressions->parse(), which - like the Ruby variant - returns an object on which you can call either a stringify() method or an evaluate("@tag1", "@tag2") method.

Motivation and Context

Perl support for Cucumber and Gherkin primitives.

How Has This Been Tested?

With the test-suite that's included.

Types of changes

  • Bug fix (non-breaking change which fixes an issue).
  • New feature (non-breaking change which adds functionality).
  • Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

  • I've added tests for my code.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated the CHANGELOG accordingly.

Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As you know, I am not a perl developer, so my review is more based on the tests and the documentation.
But from what I can tell, it looks good 👌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants