Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove html-formatter from monorepo #1896

Merged
merged 2 commits into from
Feb 10, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 0 additions & 70 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -260,32 +260,6 @@ jobs:
cd compatibility-kit/javascript
make

html-formatter-javascript:
executor: docker-circleci-node-14
steps:
- attach_workspace:
at: '~/cucumber'
- run:
name: Install Headless Chrome dependencies
command: |
sudo apt update && \
sudo apt-get install --assume-yes --quiet \
gconf-service libasound2 libatk1.0-0 libatk-bridge2.0-0 libc6 libcairo2 libcups2 libdbus-1-3 \
libexpat1 libfontconfig1 libgcc1 libgconf-2-4 libgdk-pixbuf2.0-0 libglib2.0-0 libgtk-3-0 libnspr4 \
libpango-1.0-0 libpangocairo-1.0-0 libstdc++6 libx11-6 libx11-xcb1 libxcb1 libxcomposite1 libxcursor1 \
libxdamage1 libxext6 libxfixes3 libxi6 libxrandr2 libxrender1 libxss1 libxtst6 ca-certificates \
fonts-liberation libappindicator1 libnss3 lsb-release xdg-utils wget
- run:
name: html-formatter/javascript
command: |
sudo npm install --global npm@7
cd html-formatter/javascript
make
- persist_to_workspace:
root: ~/cucumber
paths:
- html-formatter/javascript/dist

json-formatter-javascript-testdata:
executor: docker-circleci-node-14
steps:
Expand Down Expand Up @@ -444,17 +418,6 @@ jobs:
cd demo-formatter/ruby
make

html-formatter-ruby:
executor: docker-circleci-ruby-26
steps:
- attach_workspace:
at: '~/cucumber'
- run:
name: html-formatter/ruby
command: |
cd html-formatter/ruby
make

json-to-messages-ruby-testdata:
executor: docker-circleci-ruby-26
steps:
Expand Down Expand Up @@ -524,23 +487,6 @@ jobs:
paths:
- 'io/cucumber/config'

html-formatter-java:
executor: docker-circleci-openjdk
steps:
- attach_workspace:
at: '~/cucumber'
- attach_workspace:
at: '~/.m2/repository'
- run:
name: html-formatter
command: |
cd html-formatter/java
make
- persist_to_workspace:
root: '~/.m2/repository'
paths:
- 'io/cucumber/html-formatter'

json-to-messages-java-testdata:
executor: docker-circleci-openjdk
steps:
Expand Down Expand Up @@ -774,11 +720,6 @@ workflows:
- compatibility-kit-javascript:
requires:
- prepare-parallel
- html-formatter-javascript:
requires:
- messages-javascript
- gherkin-utils-javascript
- compatibility-kit-javascript
- json-formatter-javascript-testdata:
requires:
- json-formatter-ruby-testdata
Expand All @@ -800,7 +741,6 @@ workflows:
- fake-cucumber-javascript
- gherkin-javascript-node-14
- gherkin-utils-javascript
- html-formatter-javascript

### Ruby

Expand Down Expand Up @@ -828,11 +768,6 @@ workflows:
- json-formatter-ruby-testdata:
requires:
- prepare-parallel
- html-formatter-ruby:
requires:
- html-formatter-javascript
- messages-ruby
- compatibility-kit-javascript
- json-to-messages-ruby-testdata:
requires:
- prepare-parallel
Expand All @@ -848,11 +783,6 @@ workflows:
- config-java:
requires:
- prepare-parallel
- html-formatter-java:
requires:
- html-formatter-javascript
- messages-java
- compatibility-kit-javascript
- json-to-messages-java-testdata:
requires:
- prepare-parallel
Expand Down
1 change: 0 additions & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ PACKAGES ?= messages \
query \
json-formatter \
compatibility-kit \
html-formatter \
config \
demo-formatter \
json-to-messages
Expand Down
1 change: 0 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@
This repo contains the libraries/modules for behaviour that's common between the various Cucumber implementations. These include:

- [parsing Gherkin documents](https://github.com/cucumber/common/tree/main/gherkin) into a machine-readable object model.
- [formatting HTML output](https://github.com/cucumber/common/tree/main/html-formatter)

Most of these modules have implemnentations in multiple langages, and use shared test suites to ensure behaviour is consistent. See the [contributing guide](https://github.com/cucumber/common/blob/master/CONTRIBUTING.md) for more details.

Expand Down
1 change: 1 addition & 0 deletions compatibility-kit/javascript/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@
},
"devDependencies": {
"@cucumber/fake-cucumber": "^15.0.0",
"@cucumber/html-formatter": "18.0.0",
"@types/stream-buffers": "3.0.4",
"stream-buffers": "3.0.2",
"typescript": "4.5.5"
Expand Down
4 changes: 2 additions & 2 deletions compatibility-kit/scripts/cucumber-html-formatter
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
#!/usr/bin/env bash
set -euf
DIR="$( cd "$( dirname "${BASH_SOURCE[0]}" )" && pwd )"
EXE="${DIR}/../../html-formatter/javascript/bin/cucumber-html-formatter.js"
EXE="${DIR}/../javascript/node_modules/.bin/cucumber-html-formatter"

${EXE} --format ndjson
${EXE}
#docker run --interactive --rm cucumber/html-formatter:4.0.0 --format ndjson
1 change: 0 additions & 1 deletion html-formatter/.rsync

This file was deleted.

Loading