Cucumber expressions fix regexp parsing

[aslakhellesoy]

Summary

Fix how regexps are parsed

Details

See #253 for a description of the problem. This is an alternative implementation which leverages the existing regexp parser in TreeRegexp, which means consistency and reliability (compared to parsing regexp with regexp).

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue).
• New feature (non-breaking change which adds functionality).
• Breaking change (fix or feature that would cause existing functionality to not work as expected).

Checklist:

• I've added tests for my code.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.

[mxygem]

Sorry on the delay on a more in depth review. I trust your writing so if you don't want to wait on me, go ahead. :)

[aslakhellesoy]

Hey @jaysonesmith thanks for the heads up. The review request was also meant as a heads up for you to look at the implementation because you started it originally. I'll press on.

[mxygem]

Oh, I've done a brief look at it, but at some point, I'd love to setup up a break point and walk through it step by step to gain a better understanding. 👍

[mxygem]

LGTM (the java stuff is all too foreign for me to comment on.)

[mxygem]

Woot!!

[lock]

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.