Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/remove before hook in attachments #102

Merged
merged 5 commits into from
Jul 9, 2024
Merged

Refactor/remove before hook in attachments #102

merged 5 commits into from
Jul 9, 2024

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Jul 5, 2024 •
edited
Loading

🤔 What's changed?

Removed before hook that is blank

⚡️ What's your motivation?

Fixes up some tech debt we know we need to fix up. Fixes #83

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 💥 Breaking change (incompatible changes to the API)

♻️ Anything particular you want feedback on?

Will be a breaking change

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill requested a review from davidjgoss July 5, 2024 13:50
@luke-hill luke-hill mentioned this pull request Jul 5, 2024
Closed
mpkorstanje
mpkorstanje approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@mpkorstanje mpkorstanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@luke-hill luke-hill merged commit e8e0e90 into main Jul 9, 2024
7 checks passed
@luke-hill luke-hill deleted the refactor/remove-before-hook-in-attachments branch July 9, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpkorstanje mpkorstanje mpkorstanje approved these changes

@davidjgoss davidjgoss davidjgoss approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CCK: Investigate removal of Before-Hook in attachments feature
3 participants
@luke-hill @davidjgoss @mpkorstanje