Samples: Add "Empty" Sample #103
Conversation
luke-hill
requested review from
mattwynne,
brasmusson,
davidjgoss and
mpkorstanje
| {"testCaseStarted":{"attempt":0,"id":"14","testCaseId":"12","timestamp":{"nanos":5000000,"seconds":0}}} | ||
| {"testStepStarted":{"testCaseStartedId":"14","testStepId":"11","timestamp":{"nanos":6000000,"seconds":0}}} | ||
| {"testStepFinished":{"testCaseStartedId":"14","testStepId":"11","testStepResult":{"duration":{"nanos":0,"seconds":0},"status":"UNDEFINED"},"timestamp":{"nanos":7000000,"seconds":0}}} | ||
| {"testCaseFinished":{"testCaseStartedId":"14","timestamp":{"nanos":8000000,"seconds":0},"willBeRetried":false}} |
There was a problem hiding this comment.
This does not look right to me. It looks like fake-cucumber is pulling in the Background from the previous rule. Otherwise this scenario would not have any steps. I would definitely start with a much simpler test case.
There was a problem hiding this comment.
I'll resolve this generation later on once we've got the other item merged and released and we know next steps.
|
ping @brasmusson / @davidjgoss / @mattwynne - Do we think the scenario AS IS now is the best representation. I think Step 1 of the 3 is essentially complete now. |
luke-hill
force-pushed
the
feature/add-empty-sample
branch
from
4f1e26e to
25eb20e
Compare
# Conflicts: # CHANGELOG.md # devkit/package-lock.json # devkit/package.json
There was a problem hiding this comment.
@luke-hill I've updated after fixing fake-cucumber and am happy with this as the standard expected behaviour.
@mpkorstanje @brasmusson @mattwynne what do you think?
|
@davidjgoss - I think this is good now. Let's discuss in the next meeting we all remember to come to. As we've not added new behaviours to the CCK for a while. Let's also agree how we should go forward with other new CCK examples e.t.c. |
🤔 What's changed?
Adds a new item to the CCK Spec (For discussion), the Empty Sample. Fixes #92
⚡️ What's your motivation?
We've discussed this for years and never got anywhere. I figure at least we can agree on what the spec should be (I think having a background and a non-background empty scenario is best as it covers both use cases).
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Steps to agree
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.