Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Samples: Minor refactor/bugfix for example-tables #104

Merged
merged 1 commit into from
Jul 9, 2024

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

Just some alignment / tidy ups as I was struggling to get examples to pass

⚡️ What's your motivation?

Keep things aligned with all other styles (Order of steps / correctness of steps)

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

This will also go into the next major release alongside the work on attachments

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill luke-hill requested a review from mpkorstanje July 9, 2024 11:47
@mpkorstanje mpkorstanje merged commit 8f9ac5e into main Jul 9, 2024
7 checks passed
@mpkorstanje mpkorstanje deleted the refactor/reconcile-parameterized-examples branch July 9, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants