Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CCK: Reconcile unknown-parameter-type #61

Merged
merged 2 commits into from
Oct 11, 2023

Conversation

luke-hill
Copy link
Contributor

@luke-hill luke-hill commented Oct 10, 2023

🤔 What's changed?

unknown-parameter-type now is consistent for ruby/js

⚡️ What's your motivation?

Goes towards completion of issue in tracker

🏷️ What kind of change is this?

  • 🏦 Refactoring/debt/DX (improvement to code design, tooling, documentation etc. without changing behaviour)
  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

Do we need to fix anything else (I'm deliberately not regenerating the ndjson yet because there are a bunch of these that will need re-generating each time).

To avoid conflicts I'll re-generate once after merging several of these fixes

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

Copy link
Contributor

@davidjgoss davidjgoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the change in error message from the sample steps means we should regenerate as it will affect the output.

@luke-hill
Copy link
Contributor Author

Yep. I just didn't want bucketfuls of conflicts.

What I'm proposing is to merge a few of these and then regenerate afterwards just to save time.

@luke-hill luke-hill merged commit b3ae076 into main Oct 11, 2023
@luke-hill luke-hill deleted the bugfix/reconcile_unknown_param_type branch October 11, 2023 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants