CCK: Reconcile attachments #69
Conversation
… previous reconciliation was done incorrectly
There was a problem hiding this comment.
On this PR and others we have made a lot of changes but the need for all of them isn't clear. I think in general we should be keeping the scope of changes to a minimum, especially where it would reduce coverage or require existing implementations to redo steps.
Bear in mind the fake-cucumber steps and Ruby steps are not equal constituents - the former are the reference point and implementations are in theory supposed to conform.
| When a JPEG image is attached | ||
|
|
||
| Scenario: Attaching images in examples |
There was a problem hiding this comment.
Why have we removed this one?
There was a problem hiding this comment.
We've just simplified the code. Examples tables are covered in a diff feature
There was a problem hiding this comment.
They are but I don't think that one includes attachments?
|
@davidjgoss fixed up the before hook issue and made a new issue here: #83 for us to investigate this post reconciliation work. I believe the other 2 items are just redundant pieces of code, hence removing them and trying to keep everything clean and lean |
🤔 What's changed?
attachmentsare now is consistent for ruby/js.⚡️ What's your motivation?
Goes towards completion of issue in tracker
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Do we need to fix anything else (I'm deliberately not regenerating the ndjson yet because there are a bunch of these that will need re-generating each time).
To avoid conflicts I'll re-generate once after merging several of these fixes
📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.