Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hotfix: Avoid confusing path situation where no CCK tests are found #95

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

luke-hill
Copy link
Contributor

🤔 What's changed?

The way ruby is autoloading code it's causing a method conflict. So just use 2 diff names.

⚡️ What's your motivation?

We want to have the same namespace (Although maybe we shouldn't). So for now this will load the path in 2 diff ways (Intended)

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

♻️ Anything particular you want feedback on?

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@luke-hill
Copy link
Contributor Author

EDIT: Do not merge yet. This might be something we can mitigate locally

@luke-hill luke-hill self-assigned this Jan 8, 2024
@luke-hill luke-hill merged commit 5e49582 into main Jan 8, 2024
7 checks passed
@luke-hill luke-hill deleted the hotfix/duplicate_paths branch January 8, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant