Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various documentation improvements #1240

Merged
merged 8 commits into from
Dec 15, 2019
Merged

various documentation improvements #1240

merged 8 commits into from
Dec 15, 2019

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Oct 8, 2019

@davidjgoss
Copy link
Contributor Author

@charlierudolph are you okay with the changes here?

docs/cli.md Outdated Show resolved Hide resolved
docs/cli.md Outdated Show resolved Hide resolved
@charlierudolph
Copy link
Member

charlierudolph commented Dec 14, 2019

Yep. Looks good thanks for the updates. Was a bit apprehensive about the function definition wrapper docs as that was originally only intended for wrapping generators before async/await existed. Really want to get the before / after step hooks in, so we can kill that.

@davidjgoss davidjgoss merged commit 4a82d6a into master Dec 15, 2019
@davidjgoss davidjgoss deleted the docs-various branch December 15, 2019 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants