Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace use of any in value checker with generic type #1734

Closed
wants to merge 5 commits into from
Closed

Replace use of any in value checker with generic type #1734

wants to merge 5 commits into from

Conversation

mattwynne
Copy link
Member

Description

See details in commit and commit message.

Motivation & context

Partial fix for #1648

Type of change

  • Refactoring/debt (improvement to code design or tooling without changing behaviour)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover any changes to behaviour of the code.
  • All new and existing tests passed.

cucumber-ensemble and others added 2 commits July 14, 2021 20:51
@cucumber-ensemble @mattwynne
Explain how to use yarn to list commands
9ae15e1 
Co-authored-by: Matt Wynne <matt@mattwynne.net>
@cucumber-ensemble @artismarti
@eoola @16sheep @mattwynne
Make parameter type generic for value checker
18b3ff3 
Co-authored-by: Arti <artismarti@gmail.com>
Co-authored-by: Demi <eoola@wpi.edu>
Co-authored-by: Marju <marjutubli@gmail.com>
Co-authored-by: Matt <matt@cucumber.io>
@coveralls
Copy link

coveralls commented Jul 16, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 98.247% when pulling cc27fb2 on 1648-replace-any into dd62cbb on main.

aurelien-reeves
aurelien-reeves suggested changes Jul 19, 2021
View reviewed changes
CONTRIBUTING.md Outdated Show resolved Hide resolved
@aurelien-reeves
Copy link
Contributor

aurelien-reeves commented Jul 20, 2021 •
edited
Loading

We should merge that change in and rebase this branch. I don't know why, but the build has been stuck on that other branch.

The build shows the following error:

 Error : .github#L1
actions/checkout@v2, actions/setup-node@v2, actions/checkout@v2, actions/setup-node@v2, coverallsapp/github-action@master, actions/checkout@v2, and actions/setup-node@v2 are not allowed to be used in cucumber/cucumber-js. Actions in this workflow must be: within a repository owned by cucumber.

Someone may have updated the settings of the repo to allow local actions only!?
I suggest to 'allow select actions' including github ones and coveralls

@mattwynne
Copy link
Member Author

Superseded by #1764

@mattwynne mattwynne closed this Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurelien-reeves aurelien-reeves aurelien-reeves requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattwynne @coveralls @aurelien-reeves @cucumber-ensemble