-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(esm): fix esm/commonjs compatibility issues with custom formatters/snippets #1903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Their most recently public accepted PR is: #1895 |
davidjgoss
changed the title
fix: slim down exports config to resolve import/require issues
fix(esm): fix esm/commonjs compatibility issues
Jan 29, 2022
davidjgoss
force-pushed
the
fix/deep-imports-and-esm
branch
from
January 29, 2022 18:08
5cf1ea3
to
42478bd
Compare
davidjgoss
changed the title
fix(esm): fix esm/commonjs compatibility issues
fix(esm): fix esm/commonjs compatibility issues with custom formatters/snippets
Feb 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Handle all permutations of exporting a custom formatter or snippet class from userland code, across ESM and CommonJS.
It's ugly but it works and has solid tests, and when we get to a point (probably in another 1-2 major releases) when we can go ESM only then most of the complexity can be removed.
Also, add a couple of missing things to the main export.
Motivation & context
To prevent regression from current functionality as we switch from
require
toimport
. This was affecting the pretty formatter with the latest RC.Type of change
Checklist: