fix: ensure absolute paths (as file urls) can be loaded for formatters, snippets #1963
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
As part of the ESM support, we started loading formatters and snippet syntaxes with
await import()
. Unlikerequire()
, paths you pass toimport()
have to be a valid URL, and for absolute paths that means using thefile://
scheme.This PR:
file://
URLfile://
URLs are correctly accounted for when parsing the--format
option (which unfortunately uses:
as the delimiter)This will also be called out in the migration guide via #1962
⚡️ What's your motivation?
Fixes #1920.
🏷️ What kind of change is this?
📋 Checklist: