-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
support: add ability to name hooks #1994
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidjgoss
changed the title
feat(support): add ability to name hooks
support: add ability to name hooks
Apr 10, 2022
davidjgoss
requested review from
aurelien-reeves,
charlierudolph and
mattwynne
and removed request for
aurelien-reeves
April 15, 2022 18:00
aurelien-reeves
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 What's changed?
This PR adds support for named
Before
andAfter
hooks via this backwards-compatible signature:⚡️ What's your motivation?
Fixes cucumber/common#1079. Part of cucumber/messages#73
🏷️ What kind of change is this?
♻️ Anything particular you want feedback on?
Only implemented for
Before
/After
and notBeforeAll
/AfterAll
orBeforeEach
/AfterEach
- since we don't expose those hooks in formatters there seemed little point in allowing users to supply a name that doesn't go anywhere, but I'm open to feedback there.📋 Checklist:
This text was originally generated from a template, then edited by hand. You can modify the template here.