Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add config for node 18 testing #2007

Merged
merged 2 commits into from
Apr 21, 2022
Merged

add config for node 18 testing #2007

merged 2 commits into from
Apr 21, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 21, 2022 •
edited
Loading

🤔 What's changed?

Add Node.js 18 to our tested engines.

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 21, 2022 •
edited
Loading

Coverage Status

Coverage remained the same at 98.238% when pulling e703fb6 on feat/node-18 into 31a1a8b on main.

aurelien-reeves
aurelien-reeves approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@aurelien-reeves aurelien-reeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

\o/

@davidjgoss davidjgoss marked this pull request as ready for review April 21, 2022 07:13
@davidjgoss davidjgoss requested a review from a team as a code owner April 21, 2022 07:13
@davidjgoss davidjgoss merged commit 66f0012 into main Apr 21, 2022
@davidjgoss davidjgoss deleted the feat/node-18 branch April 21, 2022 07:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aurelien-reeves aurelien-reeves aurelien-reeves approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@davidjgoss @coveralls @aurelien-reeves