Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: readd old bin alias for backwards compat #2008

Merged
merged 2 commits into from
Apr 22, 2022
Merged

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented Apr 22, 2022

🤔 What's changed?

Re-add the original cucumber-js bin file alongside the cucumber.js one (which was renamed from the former in #1993).

⚡️ What's your motivation?

Backwards compatibility - these files should not be referenced directly, but it happens in the wild anyway.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented Apr 22, 2022

Coverage Status

Coverage remained the same at 98.238% when pulling 47ea581 on fix/old-bin-alias into 66f0012 on main.

@davidjgoss davidjgoss merged commit 798a864 into main Apr 22, 2022
@davidjgoss davidjgoss deleted the fix/old-bin-alias branch April 22, 2022 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants