Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix return type of step hook function to allow async #2038

Merged
merged 4 commits into from
May 14, 2022

Conversation

davidjgoss
Copy link
Contributor

@davidjgoss davidjgoss commented May 10, 2022

🤔 What's changed?

Fix return type of step hook function to allow async, to be more accurate and prevent compile/lint errors for users.

⚡️ What's your motivation?

Fixes #2037.

🏷️ What kind of change is this?

  • 🐛 Bug fix (non-breaking change which fixes a defect)

📋 Checklist:

  • I agree to respect and uphold the Cucumber Community Code of Conduct
  • I've changed the behaviour of the code
    • I have added/updated tests to cover my changes.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • Users should know about my change
    • I have added an entry to the "Unreleased" section of the CHANGELOG, linking to this pull request.

This text was originally generated from a template, then edited by hand. You can modify the template here.

@coveralls
Copy link

coveralls commented May 10, 2022

Coverage Status

Coverage remained the same at 98.33% when pulling 06a0b85 on fix/step-hook-type into 67b1ce2 on main.

@davidjgoss davidjgoss merged commit c3e6b12 into main May 14, 2022
@davidjgoss davidjgoss deleted the fix/step-hook-type branch May 14, 2022 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BeforeStep and AfterStep hooks do not allow asynchronous functions - linting (es-lint) error
4 participants